Thomas Holmes <tho...@devminded.com> added the comment: I have made a patch based on your suggestions made to higery, Éric. I have two questions:
1) In Distributions.get_reinitialized_command should the reinitialization of the subcommands also get passed the kwargs? Unfortunately my understanding of the (sub)command flow is not rock solid. 2) What are your thoughts on an effective test for this? This command does not currently have one. I believe I know a simple way to test the new kwargs functionality but if one were to write a test for get_reinitialized_command I think it should probably test the rest of the function as well. Thoughts? ---------- hgrepos: +39 nosy: +thomas.holmes _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12344> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
