New submission from Tycho Andersen <ty...@tycho.ws>:
The attached patch fixes two bugs which manifest as infinite recursion in
_insert_printable_char() of Textbox. First, the previous implementation of
_insert_printable_char() used recursion to move characters when inserting a
character. Thus, any Textpad which had an area greater than the interpreter's
maximum recursion limit would crash. A minimal test case is the following:
#!/usr/bin/python
import curses
from curses.textpad import Textbox
def main(stdscr):
box = Textbox(stdscr, insert_mode=True)
box.stripspaces = True
while 1:
cmd = box.edit()
if cmd == 'q':
break
curses.wrapper(main)
Run that script in a terminal with area (i.e. $LINES * $COLUMNS) > 1000 (the
default max recursion limit), press any key and be greeted by a stack trace.
The patch changes the implementation of _insert_printable_char() to be
iterative, thus avoiding the infinite recursion.
Second, when the underlying curses window was resized to be smaller than it was
when the Textpad was created, pressing any key would result in infinite
recursion (or with the new method, an infinite loop). The patch also changes
Textpad so that instead of keeping the underlying window's size as instance
attributes of this Textpad, Textpad asks the underlying window its size every
time Textpad needs to know, allowing the underlying window to be resized at
will.
I've verified this bug is in 2.7.1 and 3.2. Let me know if you need anything
else.
----------
components: Library (Lib)
files: textpad_resize.patch
keywords: patch
messages: 144559
nosy: tycho
priority: normal
severity: normal
status: open
title: Infinite recursion in curses.textpad.Textbox
type: crash
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file23249/textpad_resize.patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13051>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
