Charles-François Natali <neolo...@free.fr> added the comment:

Hello,

method:: socket.getsockopt(level, optname[, optarg])

The overloading of the third parameter is confusing: it can already be an 
integer value or a buffer size, I don't think that adding a third possibility 
is a good idea. It might be better to add another optional `buffer` argument 
(and ignore `buflen` if this argument is provided).

Also, it would be nice to have a corresponding unit test: since I doubt this 
buffer argument is supported by many Unices out there, you can probably reuse a 
subset of what ipset does (just take care and guard it by 
@support.requires_linux_version() if applicable).

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13045>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to