Éric Araujo <mer...@netwok.org> added the comment: I made another review but my mail was rejected.
http://bugs.python.org/review/4489/diff/3383/10563#newcode319 Lib/test/test_shutil.py:319: @unittest.skipIf(threading == None, 'requires threading') You can just say skipUnless(threading, 'msg') http://bugs.python.org/review/4489/diff/3383/10563#newcode344 Lib/test/test_shutil.py:344: raise Shouldn’t this use self.fail? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4489> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
