Terry J. Reedy <tjre...@udel.edu> added the comment:

My understanding is that an undocumented internal methods has two bugs that 
cancel, so that correct calls work correctly -- but tracebacks do not. I think 
this should be fixed, especially given a working patch.

Optionally add a doc string, which is how we usually (often, when someone gets 
around to it) do doc internal functions. Perhaps include the current comment 
(which I do not understand).

If you, Victor, are not in the contributors file, add a one-line patch for that.

Optionally (but it would certainly be good learning practice) add NEWS item. 
Something like
"Issue 13163: fix smtplib.SMTP._get_socket so that tracebacks correctly 
identity host and port arguments.
However, this is best done when someone is ready to apply and push the patch, 
as frequent changes to NEWS make patches stale.

----------
nosy: +terry.reedy
type:  -> behavior

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13163>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to