Jason Roberts <jason.robe...@duke.edu> added the comment:
Sorry, I opened issue13509 after somehow not finding this one. Here is my text
from issue13509. Thanks for looking at this problem...
Historically (i.e. Python 2.6.1 and earlier) bdist_wininst would run the post
install script at both installation and uninstallation. The script would be
invoked with a -install argument on installation and a -remove argument on
uninstallation. This stopped working in Python 2.6.2 and has not worked since.
This regression appears to have been introduced in r69094. That checkin rewrote
Run_RemoveScript and associated functions in PC/bdist_wininst/install.c. The
rewrite changed how the Python DLL was loaded during the remove scenario.
Previously Run_RemoveScript itself called Win32 LoadLibrary on the DLL name
parsed from the wininst log file. Now Run_RemoveScript calls run_installscript
instead, which ultimately calls LoadPythonDll, which calls LoadLibrary on the
pythondll global variable. But nothing initializes that variable during the
remove scenario and LoadLibrary fails. Ultimately run_installscript silently
fails and the removal proceeds to uninstall files and registry keys, with no
notification to the user that the post install script was not run.
A possible solution is to initialize pythondll in Run_RemoveScript to the DLL
name parsed from the wininst log file, e.g. by inserting the following code
prior to the call to run_installscript:
strncpy(pythondll, dllname, scriptname - 1 - dllname);
pythondll[scriptname - 1 - dllname] = '\0';
I tested this and it seemed to work fine.
I believe this problem affects all Python releases following and including
2.6.2. The version history seems to show that r69094 was propagated to all of
those releases. Presumably nobody found it because post install scripts on
removal are not widely used. They are, however, critical for my application (at
least if I want it to clean up properly on removal) so I would appreciate this
being fixed. As it stands, I have to build a private patched copy of
wininst-9.0.exe to work around this problem.
----------
versions: +Python 2.6, Python 3.1
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13276>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
