Antoine Pitrou <pit...@free.fr> added the comment:

Hello Jon, and thanks for the patch. I have a couple of comments:

- readinto() shouldn't return None but 0 when there is nothing to read (this 
corresponds to read() returning b"")

- I see _read_chunked() is only ever called with amt=None, so perhaps it can be 
simplified?

Also, a nitpick: the doc entry needs a "versionadded" tag.

----------
stage:  -> patch review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13464>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to