Mark Shannon <m...@hotpy.org> added the comment: Antoine Pitrou wrote: > Antoine Pitrou <pit...@free.fr> added the comment: > > Looking at your latest patch, I worry about "any deletion > +(including pop & popitem) causes a split table to become a combined table". > Why wouldn't you use a dummy pointer (such as ((PyObject *) 1)) to signal > deleted slots?
In fact here is no need for a dummy pointer. When deleting from a split-table, the value can just be set to NULL, the resulting key-NULL pair is legal in a split-table. Your suggestion doesn't make the code any more complex, so I've included it. In practice, it will very rare that a deletion occurs in a split table (since they are only used for attribute dictionaries). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13903> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com