Mark Shannon <m...@hotpy.org> added the comment: Review of set-with-Set.patch:
Looks good overall. I agree that restricting operations to instances of Set rather than Iterable is correct. Implementing "__rsub__" in terms of - (subtraction) means that infinite recursion is a possibility. It also creates an unnecessary temporary. Could you just reverse the expression used in __sub__? Would you add tests for comparisons; Set() == set(), etc. There are probably tested implicitly in the rest of the test suite, but explicit tests would be good. ---------- nosy: +Mark.Shannon _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8743> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
