Brett Cannon <br...@python.org> added the comment: Only two comments, otherwise LGTM (and I can't believe the solution was to go back through the import system just to pull out the cached module; the things we would change if we were doing this from scratch).
One, you have some "XXX False" markers in the tests. Should those get deleted or replaced with something? Two, in your first test (at least) you only test what is in sys.modules once instead of after each attempted import. I would repeat the test after each import. ---------- assignee: -> pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue14583> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
