Chris Jerdonek added the comment: I haven't commented on the content of your patch (I'm not knowledgeable enough in this area), but as for your test, I noticed that you removed the part that asserted something about the argument passed to cb().
Ideally when testing a callback, you want to test whatever is important about it, like: that it gets called at the right times (and as many times as it should), and that it is getting passed the right data. So you might also want to make whatever assertions are appropriate about the packet(s) passed to cb(). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue15464> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
