Gregory P. Smith added the comment:

Yes, something along the lines of that patch is what I was thinking.  BTW, this 
is only necessary for the errpipe_write fd.  errpipe_read is for the parent 
process.

I'm going to do it within _create_pipe so that the optimal 
_posixsubprocess.cloexec_pipe pipe2() based implementation can be used when 
possible rather than needing to call _set_cloexec() on the dup'ed fd.

There are some recent Linux specific possibilities such as fcntl with F_DUPFD, 
or better F_DUPFD_CLOEXEC, that would make this a single call. Using that may 
be overkill for this situation but it looks easy enough while I'm in there.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15798>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to