Guido van Rossum added the comment:
> Considering that test_csv is failing on windows even without any changes
> related to this issue, I looked at it and came up with this patch:
>
> -----------------
> Index: Lib/test/test_csv.py
> ===================================================================
> --- Lib/test/test_csv.py (revision 58914)
> +++ Lib/test/test_csv.py (working copy)
> @@ -375,7 +375,7 @@
>
> class TestCsvBase(unittest.TestCase):
> def readerAssertEqual(self, input, expected_result):
> - with TemporaryFile("w+") as fileobj:
> + with TemporaryFile("w+", newline='') as fileobj:
> fileobj.write(input)
> fileobj.seek(0)
> reader = csv.reader(fileobj, dialect = self.dialect)
> -----------------
>
> Does this look ok? The tests pass on windows and Linux.
Yes, especially since writerAssertEqual() already uses that. :-)
I do think there is something iffy here -- the 2.x version of this
test opens the files in binary mode. I wonder what end users are
supposed to do.
__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1395>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
