Serhiy Storchaka added the comment:

> My only question is, the exception we raise now says, there invalid 
>characters in the group name, whether in our case the group name is just empty.

Good point. It would be better if you move the test outside isname() function 
and immediately raise an error with an appropriate message.

----------
nosy: +serhiy.storchaka
stage: patch review -> needs patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12759>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to