Mark Dickinson added the comment:

Looks good to me.  I can confirm that the new formulas are equivalent to the 
old, at least for positive kappa.  (They're not the same for negative kappa, 
but that shouldn't matter in this context.)

Serhiy: do you know how the original formulas arose?  I don't have access to 
the "circular data" book, or to the original Best & Fisher paper, but that use 
of b in the original code is just plain peculiar;  I wonder why on earth anyone 
would want to go about computing  `a / (2 kappa)` that way.

I'd suggest leaving off the `u3 > 0.5` to `u3 >= 0.5` change for this 
particular issue;  I understand the motivation for the change, but it's 
unrelated to this issue, and seems like unnecessary code churn to me.

A test would be good!

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue17141>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to