Greg Ward added the comment:

OK I now have two competing patches. Both are disgusting, but in different ways.

1) http://hg.gerg.ca/cpython/rev/fcf3d27f20d9
   - factor out all the string constants
   - always concatenate, do not .format()

2) http://hg.gerg.ca/cpython/rev/cebefce2cfd4
   - copy {unified,context}_diff() to {unified,context}_diff_bytes()
   - this is a future maintenance headache, guaranteed!

Feedback welcome. If anyone can see a way to unify these two approaches, or a 
third way that sucks less, I'm all ears.

----------
hgrepos: +179

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue17445>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to