Antoine Pitrou added the comment: Some comments about the patch: - unless I'm missing something, I think you should re-use the fd instead of reopening the file by name - it would be nice if copy_from accepted an open file-like object, e.g. a BytesIO instance - I don't think you need a specific file for the test; just use an existing one (e.g. __file__, or one of the data files somewhere in the test subtree) - the doc needs some "versionchanged" markers
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17673> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
