New submission from Terry J. Reedy: The patch to configSectionNameDialog.py fixes the human test (adds required arg) so it runs, adds instructions to the test, fixes a bug in name_ok, removes redundant code, adds needed spaces, de-camelcases internal names, and changes the master for the two StringVars so they can be collected [sys:1: ResourceWarning: gc: 2 uncollectable objects at shutdown [<tkinter.StringVar object at 0x02C597E0>, <tkinter.StringVar ...]]. (I plan to open an issue about this.)
The new mock_tk.py adds generic mocks for tkinter String/Int/BooleanVars and tkinter.messagebox and its 8 functions. The new test_name_dialog.py uses these to unittest the non-gui parts of the dialog. The backport to 2.7 required changes to the tkinter imports and print in configSectionNameDialog.py and in test_config_name.py, addition of '.im_func' to the names of methods/functions being added to the dummy class. Both unittests and human tests run on all three branches. I believe the patches are ready to commit. ---------- components: IDLE files: config_name.diff keywords: patch messages: 190572 nosy: terry.reedy priority: normal severity: normal stage: commit review status: open title: idlelib.configSectionNameDialog: fix and add tests and mocks type: behavior versions: Python 2.7, Python 3.3, Python 3.4 Added file: http://bugs.python.org/file30459/config_name.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18130> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com