Serhiy Storchaka added the comment:
Sorry that I was late with review. Here is some nitpicks from me.
Using assertRaises() as context manager in this case looks cleaner to me:
with self.assertRaises(ValueError):
unpickler.memo = {-1: None}
Moving the `if (idx == -1 && PyErr_Occurred())` check inside the `if (idx < 0)`
block will increase the perfomance a little.
----------
nosy: +serhiy.storchaka
status: pending -> open
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue18339>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
