Guido van Rossum added the comment: I prefer two prettier loops over one less pretty one in this case. No opinion about _intenum_converter yet. (IMO refactoring can always be lazy, i.e. after you have multiple copies of the same code there's time to consider whether you should unify them and what the pros and cons are.)
On Fri, Aug 30, 2013 at 6:55 AM, Eli Bendersky <rep...@bugs.python.org>wrote: > > Eli Bendersky added the comment: > > [Thanks, Guido] > > Attaching patch with SOCK_* constants converted as well. The module > globals are currently walked twice, once to extract AF_* and once SOCK_*. > This is not a real performance problem, but should we fold it into a single > loop that collects two dicts? The code will be less pretty but more > efficient. > > Another issue is _intenum_converter. Ethan - do you think it belongs in > the enum module as a helper function or something of the sort? > > ---------- > Added file: > http://bugs.python.org/file31521/socket-intenum-af-type.6.patch > > _______________________________________ > Python tracker <rep...@bugs.python.org> > <http://bugs.python.org/issue18720> > _______________________________________ > ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18720> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
