Christian Tismer added the comment: Hi Georg, So do you think it is ok this way? I was not sure if extending the function with an optional arg is ok, or if a method to configure PyZipFile would be better. At the moment I just needed the simple functionality. Should it maybe get a regex like compileall.py ?
And a general question: What is the right constraint for a filter function? As I wrote it, returning nothing would simply be treated as "False". Maybe it is better to enforce a return value which explicitly forbids to be just None, which often just means "I forgot the return value" ? About feature or fix: Well, I need this for python2.7, because without it, the whole purpose of PyZipFile is pretty questionable. I might argue it a fix, because it crashes on the standard library ;-) Anyway, tell me and I'l add test, docs and put it into dev. cheers - chris ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue19274> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
