Martin v. Löwis added the comment:

I can't see anything wrong with the feature. Of course, the patch itself
lacks changes to the test suite.

Ideally, there would also be changes to the documentation, but as
PyMemberDef seems to be undocumented currently, it's unfair to ask for
documentation with this patch. If documentation was made, it should list
for each T_ constant what the corresponding C type should be.

I think the cast to long (in PyBool_FromLong) is redundant.

----------
assignee: loewis -> 

_____________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1720595>
_____________________________________
_______________________________________________
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to