Serhiy Storchaka added the comment:

_PyType_GetDocFromInternalDoc and _PyType_GetTextSignatureFromInternalDoc 
declarations are too long. could you please wrap them around?

First parameter of class methods (e.g. dict.fromkeys) now has a type of object 
(PyDictObject *) instead of PyTypeObject * (or PyDict_Type *).

There is redundant cast in dict___contains__:

    register PyDictObject *mp = (PyDictObject *)self;

First parameter of static methods (e.g. str.maketrans) now has a type of object 
(PyUnicodeObject *) instead of void *.

There is redundant cast in unicodedata_UCD_decimal_impl:

    PyUnicodeObject *v = (PyUnicodeObject *)unichr;

Perhaps here should be os.path.dirname() instead of os.path.basename():

    dirname = os.path.basename(destination.filename)

The 'fail("Can't write to destination "' line is too long. And I think it will 
look better if use string formatting.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20390>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to