Benjamin Peterson added the comment:

A few comments
- Your docstring for set_tunnel claims the method sends CONNECT when it in fact 
doesn't touch the network at all.
- Instead of 3 parallel arrays for tunnel information, it would be better to 
have a TunnelInfo class to contain host/port/headers (perhaps a namedtuple?).

----------
nosy: +benjamin.peterson

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7776>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to