R. David Murray added the comment: Thanks for working on this. The patch looks pretty good. I would prefer to flow the two lines in the Lock docstring as a paragraph, rather than have once sentence per line. Also, the OP mentions that the docs for type(Lock) mention PyThread_allocate_lock...do you want to look at fixing that as well? As mentioned, it should reference Lock() instead. The reference to PyThread_allocate_lock should be moved into comments in the type, IMO.
Also, this patch may be affected by the Argument Clinic Derby. I don't know if the threading module is one of the ones that is being converted or not. You can just ignore that issue since the full patch is needed for 3.3, but if you feel like figuring it out, and it is affected, you could produce an additional patch for 3.4. Otherwise whoever applies your patch will figure out how to merge it. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18916> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
