Vajrasky Kok added the comment: Here is the updated patch addressing Zachary's reviews (Thanks!). However, there are some reviews that I could not implement.
1. "This is a good candidate for a custom return converter." I can not synchronize struct rlimit and NULL return values. 2. "Should be 'class float "PyFloatObject *" "&PyFloat_Type"'. Using PyFloatObject * instead of PyObject * may require some casts to PyObject * in some places, but it's better to use the real name." I tried it but it was like opening pandora box. It's too much effort to surpress compile errors and warnings. And casting PyFloatObject to PyObject in many places, such as functions, macros, makes me nervous. I think this one deserves a dedicated ticket. ---------- Added file: http://bugs.python.org/file33887/issue20185_conglomerate_v2.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20185> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
