Serhiy Storchaka added the comment:
Besides insignificant style nitpick ("if classdict.get('__reduce_ex__') is
None" can be written as "if '__reduce_ex__' not in classdict") the patch LGTM
at first glance. I'm not very familiar with Enum's complicated machinery and
don't sure that no bugs left here (I'm not sure that we should sabotage
pickling at all, other types have no such paranoid guard), but at least I'm
sure this patch doesn't make things worse. On other hand, this doesn't look as
critical bugfix and may be can wait for 3.4.1. Ethan's, Eli's and Barry's
opinions have more weight in this matter.
----------
nosy: +barry, eli.bendersky, serhiy.storchaka
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue20679>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
