Nick Coghlan added the comment:

I think there's still value in giving someone experience with the current patch 
development process, as well as looking for potentially genuine readability 
improvements.

However, I also agree that automated compliance with a style guide checker 
can't sensibly be retrofitted to an existing project, even if that project is 
the originator of the style guide (it generates too much noise in the code 
history, and risks creating spurious merge conflicts for other changes. In the 
specific case of the standard library, we also sometimes make exceptions to the 
style guide to reduce code churn when merging in an existing project, as 
happened in the case of ipaddress).

In this case, I like the alignment fixes in the custom assertion methods, so 
I'll probably apply those as a small readability improvement.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20815>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to