STINNER Victor added the comment: > FYI, the two are not equivalent.
I don't get your point, the purpose of the change is to get ride of "except: pass" which is *bad*. > Even then, the new code would be slower than the original, I don't understand why you are talking about performances here. Ignore SystemExit and KeyboardInterrupt is a huge bug, performances don't matter here. I don't want to benchmark, but I expect that performances are exactly the same if no exception is raised. Please don't close the issue, Stéphane is fixing real bug. I agree that it would be better to split the large patch is shorter parts. Or all changes replacing "except: pass" should be grouped into the same patch. Replacing "except: <code>; raise" with "except Exception: <code>; raise" is wrong. ---------- resolution: rejected -> status: closed -> open _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21259> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
