akira added the comment: > I really don't like the use_fallback argument ..
I initially also thought so. But I've suggested the parameter to replace `(was_os_sendfile_used, os_sendfile_error)` returned value as a *trade off* between a slight complexity in the interface vs. allowing to detect performance bugs easily e.g., when someone passed a file-like object incompatible with os.sendfile by accident (it is not enough to have a valid fileno. What mmap-like means?). > .. as a user, I don't care if it's using sendfile/splice/whatever WIndows > uses. > .. what do this bring? The reason sendfile exists is performance. Otherwise socket.makefile and shutil.copyfileobj could be used instead. use_fallback parameter provides a way to assert that an ineffective fallback is not used by accident. It may be ignored by most users. An alternative is a new separate public method that doesn't use the fallback. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17552> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
