Tim Golden <[EMAIL PROTECTED]> added the comment: Gabriel Genellina wrote: > Gabriel Genellina <[EMAIL PROTECTED]> added the comment: > > You aren't testing the modified code, the Popen call should say > shell=True. > > I think that a more PEP8-compliant style would be nice (removing the > spaces after open and read, and using consistent indentation)
D'oh. Thanks, Gabriel. I'll rework the test and tidy up the patch. ---------- title: subprocess under windows fails to quote properly when shell=True -> subprocess under windows fails to quote properly when shell=True __________________________________ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2304> __________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
