Matt Frank added the comment: >> audioop_ctypes_test_link_with_libm.patch > + libraries=['m']) > Why not using math_libs here?
math_libs is defined in detect_modules(). But the _ctypes_test extension is defined in a different function: detect_ctypes(). The other option, would be to define math_libs=['m'] directly above this line and then use it once. I didn't think that added clarity, but I'd be happy to do it that way if it fits better with standard style. > It would also be nice to add a comment explaining why libm is needed in each > module. Done. > Can someone please combine both patches? Done. ---------- Added file: http://bugs.python.org/file37042/time_select_audioop_ctypes_test_link_with_libm.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21668> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
