Akira Li added the comment:
I can confirm that without the patch the filename attribute is None
despite being mentioned in strerror.
Travis, you should use `orig_executable` instead of `args[0]` to cover:
subprocess.call("exit 0", shell=True, executable='/nonexistent bash')
case.
And use `cwd` if `child_exec_never_called`, to be consistent with the error
message (see if/else statements above the raise statement).
It seems appropriate to set filename even if errno is not ENOENT
but to be conservative, you could provide filename iff `err_msg` is also
changed i.e., iff errno is ENOENT.
----------
nosy: +akira
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22536>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
