Serhiy Storchaka added the comment:
Here is updated patch.
----------
Added file: http://bugs.python.org/file37221/PyObject_REPR_2.patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22453>
_______________________________________
diff -r 0f663e0ce1d3 Doc/whatsnew/3.5.rst
--- a/Doc/whatsnew/3.5.rst Tue Nov 18 17:30:50 2014 +0200
+++ b/Doc/whatsnew/3.5.rst Tue Nov 18 19:14:09 2014 +0200
@@ -441,3 +441,7 @@ Changes in the C API
* The :c:type:`PyMemAllocator` structure was renamed to
:c:type:`PyMemAllocatorEx` and a new ``calloc`` field was added.
+
+* Removed non-documented macro :c:macro:`PyObject_REPR` which leaked
references.
+ Use format character ``%R`` in :c:func:`PyUnicode_FromFormat`-like functions
+ to format the :func:`repr` of the object.
diff -r 0f663e0ce1d3 Include/object.h
--- a/Include/object.h Tue Nov 18 17:30:50 2014 +0200
+++ b/Include/object.h Tue Nov 18 19:14:09 2014 +0200
@@ -575,9 +575,6 @@ PyAPI_FUNC(PyObject *) PyObject_Dir(PyOb
PyAPI_FUNC(int) Py_ReprEnter(PyObject *);
PyAPI_FUNC(void) Py_ReprLeave(PyObject *);
-/* Helper for passing objects to printf and the like */
-#define PyObject_REPR(obj) _PyUnicode_AsString(PyObject_Repr(obj))
-
/* Flag bits for printing: */
#define Py_PRINT_RAW 1 /* No string quotes etc. */
diff -r 0f663e0ce1d3 Python/compile.c
--- a/Python/compile.c Tue Nov 18 17:30:50 2014 +0200
+++ b/Python/compile.c Tue Nov 18 19:14:09 2014 +0200
@@ -1414,12 +1414,12 @@ get_ref_type(struct compiler *c, PyObjec
PyOS_snprintf(buf, sizeof(buf),
"unknown scope for %.100s in %.100s(%s)\n"
"symbols: %s\nlocals: %s\nglobals: %s",
- PyBytes_AS_STRING(name),
- PyBytes_AS_STRING(c->u->u_name),
- PyObject_REPR(c->u->u_ste->ste_id),
- PyObject_REPR(c->u->u_ste->ste_symbols),
- PyObject_REPR(c->u->u_varnames),
- PyObject_REPR(c->u->u_names)
+ PyUnicode_AsUTF8(name),
+ PyUnicode_AsUTF8(c->u->u_name),
+ PyUnicode_AsUTF8(PyObject_Repr(c->u->u_ste->ste_id)),
+
PyUnicode_AsUTF8(PyObject_Repr(c->u->u_ste->ste_symbols)),
+ PyUnicode_AsUTF8(PyObject_Repr(c->u->u_varnames)),
+ PyUnicode_AsUTF8(PyObject_Repr(c->u->u_names))
);
Py_FatalError(buf);
}
@@ -1476,11 +1476,11 @@ compiler_make_closure(struct compiler *c
fprintf(stderr,
"lookup %s in %s %d %d\n"
"freevars of %s: %s\n",
- PyObject_REPR(name),
- PyBytes_AS_STRING(c->u->u_name),
+ PyUnicode_AsUTF8(PyObject_Repr(name)),
+ PyUnicode_AsUTF8(c->u->u_name),
reftype, arg,
- _PyUnicode_AsString(co->co_name),
- PyObject_REPR(co->co_freevars));
+ PyUnicode_AsUTF8(co->co_name),
+ PyUnicode_AsUTF8(PyObject_Repr(co->co_freevars)));
Py_FatalError("compiler_make_closure()");
}
ADDOP_I(c, LOAD_CLOSURE, arg);
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
