Justin Ferguson <[EMAIL PROTECTED]> added the comment: > 1. If you change PyString_FromStringAndSize, you should change > PyBytes_FromStringAndSize and PyUnicode_FromStringAndSize for > consistency.
Okay, if we don't patch the API call itself, I will look at the users of those two API calls as well, I haven't gone through much of the stuff in Objects/ yet, I focused on the modules obviously and thus didn't know about those calls. > 4. You have clearly identified several bugs that are not covered by > unittests. If you fix them en-mass by making > PyString_FromStringAndSize more forgiving, we will miss an opportunity > to improve the test coverage. (If you take the SystemError approach, > this does not apply.) This is a valid and good point-- I don't mind either way __________________________________ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2587> __________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
