Wei Wu added the comment:
The last approach I proposed requires some change in "template code" of
check_xxx methods. To make it better, we can add a bool parameter to the
check_xxx functions, True value indicating a fd test. If a filename is given at
the same time, then a fd can get from that file. Otherwise the fd should be
sys.stderr.fileno().
e.g.
file = None
fp = None
if filename:
fp = open(filename, "wb")
# Must use a different name to prevent the file from closing...
file = fp
if fd:
if fp is not None:
file = fp.fileno()
else:
file = sys.stderr.fileno()
# file can be file-object, fd or None
(use_the_file_to_function...)
The fd-passing approach can co-exist with this one. However it will make
"template code" more complex. So I suggest just use one approach to write these
fd tests.
I will work on a patch(based on tip) at this weekend.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23566>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
