Guido van Rossum <[EMAIL PROTECTED]> added the comment:

Code review:

Objects/rangeobject.c:

line 259-260:
AFAIK register is completely useless in this day and age; drop it.

line 296 and further:
Please move the || and && operators to the end of the previous line.

line 313 etc:
This all fits on one line.

Line 319-320:
Ditto.

Line 361:
Please make the comment line up.

Lib/test/test_builtin.py:
I'd like to see another test indicating which of the following is true:

range(0, 11, 2) == range(0, 10, 2)

or

range(0, 11, 2) != range(0, 10, 2)

(since they produce the same sequence of values).

Also, add a test for __hash__() of a range().

__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2603>
__________________________________
_______________________________________________
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to