STINNER Victor added the comment: > The patch doesn't contain tests because I can't test them. But they should be > simple, just pass a path with null character to os function.
IMO this issue is a bug, so you must write an unit test to test for non regression. One test for FileIO, another for the os module should be enough, and you can test them on UNIX since the behaviour now must be the same. Except of the test, path_converter_null_char.patch looks good to me. Do you want to fix Python 2.7 and 3.4? A filename with an embedded null character can be a security vulnerability, so it's good to fix these versions too. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23908> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
