Berker Peksag added the comment:

Thanks for the patches, Ilia. The one for 2.7 looks good.

Reviewing 20362_py35.patch:

* Looks almost identical to issue20362.diff except style changes and the two 
comments below, right?

* -            self.assertIn("'kot'", e.args[0])

  Why did you remove this line?

* +    assertNotRegexpMatches = _deprecate(assertNotRegex)

  This looks like an unrelated change, but I think it can be committed. Thanks 
for the catch!

* The tests should be updated to use assertRegex and assertNotRegex

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20362>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to