Eric V. Smith added the comment: Thanks for your review, Berker. I've updated the code with most of your suggestions, although some of them were mooted by some restructuring I did.
A couple of questions/issues: - I'm not sure where we stand on keyword-only arguments. I certainly agree that I'd never specify numeric_only unless I named it. However, I don't see a lot of that style in new or modified APIs. I'll ask over on python-dev and see what they say. - test_extract_without_numeric_owner only works if the user named 'root' has uid = 0 (same for gid). This is a different test than what test_os.root_in_posix is doing. I think it's best to leave it as-is, although I've added a comment and reduced the scope of the skip to just this one test. - I reformatted the tests to stay within 80 characters, and I think it also made them more legible. - I'm not sure what you mean by your last point. I believe I use True as it is elsewhere in that module and its documentation. And None doesn't make any sense to me as a parameter value for this. ---------- Added file: http://bugs.python.org/file38998/tarfile-numeric-owner-with-tests-4.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23193> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
