Martin Panter added the comment:

To be consistent, I think the documentation should mark up the parameters with 
asterisks: *quote_via*. Also, you lost the markup for :func:`quote_plus`.

The test cases should probably use self.assertEqual(). The “assert” statement 
is not appropriate for testing because it can be optimized away.

You also need to clarify in the documentation and tests how the “safe” 
parameter interacts with the choice of quote function. Are slashes encoded or 
not by default with quote_via=quote?

----------
nosy: +vadmium

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13866>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to