R. David Murray added the comment: I added some review comments.
Something I don't understand: if settimeout sets NONBLOCK, and CLOEXEC is always set now, why does s=socket.socket() yield something whose type is SOCK_STREAM, while settimeout causes type to change? I don't understand the relationship between SOCK_NONBLOCK and O_NONBLOCK, either. Whoever came up with this API in linux was crazy, if you ask me. On the other hand, having type return what it does is clearly correct, given that we are mirroring the C API. Having a new sock_type attribute that provides the value without the extra flags makes sense in that context, IMO. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21327> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
