Nick Coghlan added the comment: The patch mostly looks good to me, but I suggest using "test.support.check_warnings" for the cases where you're checking that the warning is raised as expected: https://docs.python.org/3/library/test.html#test.support.check_warnings
It's slightly simpler than constructing the same logic yourself using warnings.catch_warnings. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24237> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
