Martin Panter added the comment: Aaron: Your version of the fix immediately returns None, while Victor’s tries to encode an empty string (if I understand it correctly). I imagine this shortcut could be slightly more efficient, but is it always correct?
In any case, Aaron’s test looks okay to me. ---------- stage: test needed -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23247> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
