Zachary Ware added the comment: Steve Dower wrote: > I assume you're referring to #24974?
It's somewhat related, yes, but I didn't intend for the two issues to be tightly coupled. Both should be dealt with independently of each other. > The default (for MSVC) is /fp:precise, which should allow > fenv_access, but maybe ICL uses /fp:fast by default for the extra > speed? I believe that's correct. > I'm not totally opposed to allowing an extra option for setting flags > when building, but there'll almost always be a better fix. That's probably true. I will say though that it's really hard to pass build options to a buildbot. I have yet to find a way to pass properties with no spaces in the value, for example, "/p:IncludeSSL=false" (if you know of a way to pass that to MSBuild correctly through Tools/buildbot/build.bat called by 2.7's subprocess module, I'm all ears :)). To continue the floating point example, the only method (other than this) I've found to pass in a different model is to hack in another property to check and set FloatingPointModel in the ClCompile ItemDefinitionGroup, which has the same problem as the 'IncludeSSL' issue I mentioned above. With a nice simple 'CFLAGS' property that doesn't care about extra spaces in the value, it becomes possible to pass '/fp:strict' to a buildbot easily. Also, ICC has *a lot* of extra command line options that may be interesting to pass in, but I'm quite sure we don't want to hack any of them into the project files. By the way, '/fp:strict' is just what we've been manually defaulting to for ICC builds since before issue21167 was committed, which made '/fp:strict' unnecessary. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24973> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
