Adam Olsen <[EMAIL PROTECTED]> added the comment:

new_buffersize returns a size_t.  You should use SIZE_MAX instead
(although I don't see it used elsewhere in CPython, so maybe there's
portability problems.)

The call to _PyString_Resize implicitly casts the size_t to Py_ssize_t.
 The check against PY_SSIZE_T_MAX does make this safe, but a comment
would make it more obvious.

The latest patch uses spaces for indentation, which don't match up with
the existing tabs.

----------
nosy: +Rhamphoryncus

_____________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1174606>
_____________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to