STINNER Victor added the comment:

> Larry, I appreciate the vote of confidence, but I'm ill-equipped to help at 
> the patch level:  (...)  The patch(es) are too broad and delicate to be sure 
> of without kicking the tires (running contrived examples).

Well, the patches change how timedelta, .fromtimestamp() and 
.utcfromtimestamp() round the number of microseconds. It's a deliberate choice 
since it was decided that the current rounding mode is a bug, and not a feature 
:-)

The code is well tested. There are unit tests on how numbers are rounded for: 
timedelta, .(utc)fromtimestamp(), and even the C private API _PyTime. The code 
is (almost) the same in default and was validated on various platforms. So I'm 
confident on the change.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23517>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to