Martin Panter added the comment: All three patches look generally good to me. I left some comments on things I would change.
FTR the tests fail to raise any exception when the redirect limit is reached because FancyURLopener.http_error_default() does not raise an error. It just returns the last result as a synthesized error page. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12923> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com