Serhiy Storchaka added the comment: _LegalChars contained only characters which don't require quoting, as documented in the comment above. If _LegalChars was only used to create _is_legal_key, we would just wrote the regular expression. But it is used also in other places. In this particular case adding "\" to _LegalChars doesn't lead to visible bug (except inconsistency with the comment), but we can't be sure.
_is_legal_key() is implementation detail. It would be better to test public API. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26302> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com