STINNER Victor added the comment:

STINNER Victor:
>> This change looks related to the issue #21955. IMHO we should take the same 
>> decision. I mean, maybe it's better to implement the fast-path only in 
>> ceval.c? Or maybe in ceval.c and longobject.c?

Yury Selivanov:
> There is no drastic difference on where you implement the fast path.  I'd 
> implement all specializations/optimizations in longobject.c and optimize 
> ceval to call slots directly.  That way, the implact on ceval performance 
> would be minimal.

Oh wait, I was confused by my own patch for #21955 inlining int operations in 
ceval.c.

Since recent benchmarks showed slow-down when ceval.c is modified, I think that 
it's ok to modify longobject.c rather than ceval.c (and maybe only 
longobject.c, but let's discuss that in issue #21955).

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26289>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to